Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: centered the space time chart on the projected train #10833

Merged
merged 2 commits into from
Feb 18, 2025
Merged

front: centered the space time chart on the projected train #10833

merged 2 commits into from
Feb 18, 2025

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 17, 2025 •
edited
Loading

closes #9636
closes #9039

@clarani clarani requested a review from a team as a code owner February 17, 2025 16:03
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Feb 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (8a2d4ee) to head (93c0c36).
Report is 33 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #10833      +/-   ##
==========================================
+ Coverage   81.94%   82.56%   +0.62%     
==========================================
  Files        1085     1084       -1     
  Lines      107232   107272      +40     
  Branches      737      728       -9     
==========================================
+ Hits        87866    88573     +707     
+ Misses      19325    18658     -667     
  Partials       41       41
Flag Coverage Δ
editoast 74.39% <ø> (-0.01%) ⬇️
front 90.47% <100.00%> (+0.97%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clarani clarani enabled auto-merge February 17, 2025 16:07
theocrsb
theocrsb approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@theocrsb theocrsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested !

Math-R
Math-R approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clarani clarani added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2025
@SharglutDev SharglutDev added this pull request to the merge queue Feb 18, 2025
Merged via the queue into dev with commit 1354c32 Feb 18, 2025
27 checks passed
@SharglutDev SharglutDev deleted the cni/9636-get-centered-on-projected-train branch February 18, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Math-R Math-R Math-R approved these changes

@theocrsb theocrsb theocrsb approved these changes

@anisometropie anisometropie Awaiting requested review from anisometropie

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
5 participants
@clarani @codecov-commenter @Math-R @theocrsb @SharglutDev